Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in Advanced Markdown Editor extension #307

Closed
paintedsky opened this issue Sep 18, 2018 · 3 comments
Closed

Small bug in Advanced Markdown Editor extension #307

paintedsky opened this issue Sep 18, 2018 · 3 comments

Comments

@paintedsky
Copy link

Hi there,

First off- thanks for your hard work on Standard Notes, it's a great application and I really appreciate having such a full-featured option that is open source and privacy-centric.

Now, the bug: I noticed when testing out Advanced Markdown Editor, that putting a numbered list directly after a bulleted list (with one line break in between) breaks the formatting of the numbered list in Preview and Split views.

Adding an additional line break (so two line breaks in between the two lists) fixes the problem.

See the attached screenshots for an example of what I mean. First screenshot is with one line break, second is with two.

This is a small bug so I understand if you'd rather prioritize more important features, but thought I'd mention it so you can fix it when you get a chance.

Thanks!

lists_with_one_line_break

lists_with_two_line_breaks

@moughxyz
Copy link
Member

Hey @paintedsky, thanks for your support, and glad to hear you're enjoying SN! The Advanced Markdown Editor is based on the open source SimpleMDE editor (https://github.com/sparksuite/simplemde-markdown-editor), and it definitely has its quirks, like what you see here. Some of the editors we develop ourselves (like the Simple Markdown Editor and Task Editor), but for this one, our best bet of getting this resolved is opening up an issue with the developers directly and seeing what they say. If they provide a fix, we can then pull this into our version of the editor.

@paintedsky
Copy link
Author

Thanks for your speedy reply- it seems that SimpleMDE editor is no longer being maintained, so the possibility of having it fixed on their end seems unlikely.

Might be better to rework the extension based on a better editor? Obviously that's more work, but probably the best option in the long run. It looks like there's a fork of SimpleMDE called Inscryb that promises to be a drop-in replacement and might be worth looking at.

@moughxyz
Copy link
Member

Ah interesting, didn't realize it was no longer maintained. Inscryb looks like it maintains it, but only stuff related to the wrapper, and not really deep code stuff. Yeah, will have to find another open source editor we can fork.

@effieeee effieeee closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants