Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSC Custom Tag updated and message added when Bug is not updated #59

Closed
Ri7Sh opened this issue May 6, 2021 · 4 comments
Closed

SSC Custom Tag updated and message added when Bug is not updated #59

Ri7Sh opened this issue May 6, 2021 · 4 comments

Comments

@Ri7Sh
Copy link

Ri7Sh commented May 6, 2021 •
edited

@rsenden, with FortifyBugUtility-4.2, we are seeing that ADOBugState update messages are added with each bug utility run even when the ADO Bug was closed long ago or no action is taken by the user. Meanwhile, the correct behaviour would be only update custom tag when there is a change from older tag.

  1. image

  2. image
@Ri7Sh Ri7Sh changed the title SSC update message added even if the ADO Bug is closed long ago SSC Custom Tag updated and message added when Bug is not updated May 6, 2021
@Ri7Sh
Copy link
Author

Ri7Sh commented May 11, 2021

@rsenden is there any update on this?

@rsenden
Copy link
Collaborator

rsenden commented May 11, 2021

Unfortunately I don't have time to look into this right now as I'm very busy with customer engagements. I hope to have some time to look into this somewhere in the coming 2-3 weeks.

I think the utility just invokes the SSC API to set the tag value, without taking into account whether the custom tag was already set to that same value. I didn't consider that this would add a message to the issue history on every run (I assume this is why you reported this issue, correct?).

So either the utility should check the existing value before updating it, or SSC shouldn't add the history message if the custom tag isn't actually being changed. I'll need to think about and discuss with the SSC team what would be the best option.

Please ping me again if you haven't heard back in about 2 weeks.

rsenden added a commit that referenced this issue May 17, 2021
@rsenden
Fixes unneeded SSC custom tga updates (#59)
dc551af
rsenden added a commit that referenced this issue May 17, 2021
@rsenden
Fixes unneeded SSC custom tag updates (#59)
1eee39d
@rsenden
Copy link
Collaborator

rsenden commented May 17, 2021

Fix will be included in next release

@rsenden rsenden closed this as completed May 17, 2021
@rsenden
Copy link
Collaborator

rsenden commented May 17, 2021

https://github.com/fortify-ps/FortifyBugTrackerUtility/releases/tag/4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rsenden @Ri7Sh