Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Facebook metadata #575

Closed
BogdanDogaru opened this issue Aug 28, 2018 · 1 comment
Closed

Add Facebook metadata #575

BogdanDogaru opened this issue Aug 28, 2018 · 1 comment
Projects
News Article
Milestone
06. News Metadata...

Comments

@BogdanDogaru
Copy link
Contributor

BogdanDogaru commented Aug 28, 2018 •
edited by sareh

Is your feature request related to a problem? Please describe.
Our article page is currently missing metadata. This PR will add all the available Facebook meta.

Describe the solution you'd like
Add the following fields, including the logic necessary to render them correctly:

  • fb:app_id - 1609039196070050 [OR ARES]
  • fb:admin - 100004154058350 [OR ARES]

Pass in as variables, to live in a metadata config file here in lib: https://github.com/bbc/simorgh/tree/latest/src/app/lib.

Additional context
Some fields might require further discussion, and we will initially hard-code them.

Testing notes

  • Unit tests are adequate
@BogdanDogaru BogdanDogaru added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. Metadata component labels Aug 28, 2018
@BogdanDogaru BogdanDogaru added this to To do in News Article via automation Aug 28, 2018
@BogdanDogaru BogdanDogaru mentioned this issue Aug 28, 2018
Closed
@BogdanDogaru BogdanDogaru added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 28, 2018
@BogdanDogaru
Copy link
Contributor Author

Blocked waiting on #573

@jtart jtart removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Sep 5, 2018
@jtart jtart removed blocked This issue should not be worked on until another internal issue is completed - see desc for details labels Sep 26, 2018
@jtart jtart self-assigned this Sep 26, 2018
@jtart jtart moved this from To do to Issue In Progress in News Article Sep 26, 2018
@jtart jtart mentioned this issue Sep 26, 2018
Merged
2 tasks
News Article automation moved this from Issue In Progress to Done Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
News Article
  
Done
Milestone
06. News Metadata (Opengraph, Twitter...
Development

No branches or pull requests
2 participants
@BogdanDogaru @jtart